From: Jason Ish <jason.ish@oisf.net>
Date: Wed, 23 Oct 2024 15:52:18 +0000 (-0600)
Subject: misc: remove unneeded headers
X-Git-Tag: suricata-8.0.0-beta1~763
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d4a3ee163d94737d6fb1887311df6d31698a4f45;p=thirdparty%2Fsuricata.git

misc: remove unneeded headers

Remove unneeded headers from worked on in previous commits, just
simple ones flagged by clangd.
---

diff --git a/src/app-layer-dnp3.c b/src/app-layer-dnp3.c
index c2b1eb00fc..c995667ee0 100644
--- a/src/app-layer-dnp3.c
+++ b/src/app-layer-dnp3.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 2015 Open Information Security Foundation
+/* Copyright (C) 2015-2024 Open Information Security Foundation
  *
  * You can copy, redistribute or modify this Program under the terms of
  * the GNU General Public License version 2 as published by the Free
@@ -23,12 +23,8 @@
 
 #include "suricata-common.h"
 #include "suricata.h"
-#include "stream.h"
-#include "util-byte.h"
 #include "util-unittest.h"
-#include "util-hashlist.h"
 
-#include "util-print.h"
 #include "util-spm-bs.h"
 #include "util-enum.h"
 
diff --git a/src/app-layer-events.c b/src/app-layer-events.c
index 94554d2b98..eb32ea3946 100644
--- a/src/app-layer-events.c
+++ b/src/app-layer-events.c
@@ -22,11 +22,7 @@
  * \author Anoop Saldanha <anoopsaldanha@gmail.com>
  */
 
-#include "suricata-common.h"
-#include "decode.h"
-#include "flow.h"
 #include "app-layer-events.h"
-#include "app-layer-parser.h"
 #include "util-enum.h"
 
 int SCAppLayerGetEventIdByName(const char *event_name, SCEnumCharMap *table, uint8_t *event_id)
diff --git a/src/app-layer-htp.c b/src/app-layer-htp.c
index fa83aa2fed..6d4193adb7 100644
--- a/src/app-layer-htp.c
+++ b/src/app-layer-htp.c
@@ -37,23 +37,14 @@
 #include "suricata-common.h"
 #include "conf.h"
 #include "decode.h"
-#include "threads.h"
-#include "counters.h"
 
 #include "util-print.h"
-#include "util-pool.h"
-#include "util-radix-tree.h"
-#include "util-file.h"
 #include "util-byte.h"
 
-#include "stream-tcp-private.h"
-#include "stream-tcp-reassemble.h"
 #include "stream-tcp.h"
-#include "stream.h"
 
 #include "app-layer-protos.h"
 #include "app-layer-parser.h"
-#include "app-layer-expectation.h"
 
 #include "app-layer.h"
 #include "app-layer-detect-proto.h"
@@ -66,11 +57,8 @@
 #include "app-layer-htp-range.h"
 #include "app-layer-htp-mem.h"
 
-#include "util-spm.h"
 #include "util-debug.h"
-#include "util-time.h"
 #include "util-misc.h"
-#include "util-enum.h"
 
 #include "util-unittest.h"
 #include "util-unittest-helper.h"
@@ -81,8 +69,6 @@
 #include "detect-engine-state.h"
 #include "detect-parse.h"
 
-#include "decode-events.h"
-
 #include "util-memcmp.h"
 #include "util-random.h"
 #include "util-validate.h"
diff --git a/src/app-layer-smtp.c b/src/app-layer-smtp.c
index a19dd2beb9..ec4799605c 100644
--- a/src/app-layer-smtp.c
+++ b/src/app-layer-smtp.c
@@ -24,12 +24,8 @@
 #include "suricata.h"
 #include "suricata-common.h"
 #include "decode.h"
-#include "threads.h"
 
-#include "stream-tcp-private.h"
-#include "stream-tcp-reassemble.h"
 #include "stream-tcp.h"
-#include "stream.h"
 
 #include "app-layer.h"
 #include "app-layer-detect-proto.h"
@@ -41,7 +37,6 @@
 #include "util-enum.h"
 #include "util-mpm.h"
 #include "util-debug.h"
-#include "util-print.h"
 #include "util-byte.h"
 #include "util-unittest.h"
 #include "util-unittest-helper.h"
@@ -53,7 +48,6 @@
 #include "detect-engine-build.h"
 #include "detect-parse.h"
 
-#include "decode-events.h"
 #include "conf.h"
 
 #include "util-mem.h"
diff --git a/src/app-layer-ssl.c b/src/app-layer-ssl.c
index 58bfdfd918..05ba2239b2 100644
--- a/src/app-layer-ssl.c
+++ b/src/app-layer-ssl.c
@@ -26,12 +26,6 @@
 
 #include "suricata-common.h"
 #include "decode.h"
-#include "threads.h"
-
-#include "stream-tcp-private.h"
-#include "stream-tcp-reassemble.h"
-#include "stream-tcp.h"
-#include "stream.h"
 
 #include "app-layer.h"
 #include "app-layer-detect-proto.h"
@@ -40,21 +34,13 @@
 #include "app-layer-frames.h"
 #include "app-layer-ssl.h"
 
-#include "decode-events.h"
 #include "conf.h"
 
 #include "feature.h"
 
-#include "util-spm.h"
-#include "util-unittest.h"
 #include "util-debug.h"
-#include "util-print.h"
-#include "util-pool.h"
-#include "util-byte.h"
 #include "util-ja3.h"
 #include "util-enum.h"
-#include "flow-util.h"
-#include "flow-private.h"
 #include "util-validate.h"
 
 SCEnumCharMap tls_frame_table[] = {
diff --git a/src/app-layer-tftp.c b/src/app-layer-tftp.c
index 793eda8b23..4a9b41176a 100644
--- a/src/app-layer-tftp.c
+++ b/src/app-layer-tftp.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 2017-2021 Open Information Security Foundation
+/* Copyright (C) 2017-2024 Open Information Security Foundation
  *
  * You can copy, redistribute or modify this Program under the terms of
  * the GNU General Public License version 2 as published by the Free
@@ -27,17 +27,12 @@
 
 #include "suricata-common.h"
 #include "suricata.h"
-#include "stream.h"
-#include "conf.h"
-
-#include "util-unittest.h"
 
 #include "app-layer.h"
 #include "app-layer-detect-proto.h"
 #include "app-layer-parser.h"
 
 #include "app-layer-tftp.h"
-#include "rust.h"
 
 /* The default port to probe if not provided in the configuration file. */
 #define TFTP_DEFAULT_PORT "69"