From: jocuri%softhome.net <>
Date: Tue, 7 Dec 2004 01:11:15 +0000 (+0000)
Subject: Patch for bug 270589: Make t/008filter.t accept empty template directives; patch... 
X-Git-Tag: bugzilla-2.19.2~91
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d4bbccb5447134e7b09426e3199ac869e7c97563;p=thirdparty%2Fbugzilla.git

Patch for bug 270589: Make t/008filter.t accept empty template directives; patch by Marc Schumann <wurblzap@gmail.com>, r=justdave, r=myk, a=justdave.
---

diff --git a/t/008filter.t b/t/008filter.t
index 531edf28e2..bc8c6aa152 100644
--- a/t/008filter.t
+++ b/t/008filter.t
@@ -158,6 +158,9 @@ sub directive_ok {
     $directive =~ s/^[+-]?\s*//;
     $directive =~ s/\s*[+-]?$//;
 
+    # Empty directives are ok; they are usually line break helpers
+    return 1 if $directive eq '';
+
     # Exclude those on the nofilter list
     if (defined($safe{$file}{$directive})) {
         $safe{$file}{$directive}++;
diff --git a/template/en/default/filterexceptions.pl b/template/en/default/filterexceptions.pl
index f0267a6065..d7b365ffcf 100644
--- a/template/en/default/filterexceptions.pl
+++ b/template/en/default/filterexceptions.pl
@@ -136,8 +136,6 @@
   'num_bugs',
   'data.$tbl.$col.$row',
   'title',
-  '', # This is not a bug in the filter exceptions - this template has an 
-      # empty directive which is necessary for it to work properly.
 ],
 
 'reports/report-table.html.tmpl' => [