From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 4 Sep 2023 23:02:37 +0000 (+1200)
Subject: s4:kdc: Assign RID and attribute together
X-Git-Tag: tevent-0.16.0~596
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d4ceac448b6bbc0d1f51063156de960c5d2e98f1;p=thirdparty%2Fsamba.git

s4:kdc: Assign RID and attribute together

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source4/kdc/pac-glue.c b/source4/kdc/pac-glue.c
index b408e2e8efe..772118db9fe 100644
--- a/source4/kdc/pac-glue.c
+++ b/source4/kdc/pac-glue.c
@@ -1784,8 +1784,10 @@ static krb5_error_code samba_kdc_add_domain_group_sid(struct PAC_DEVICE_INFO *in
 
 	domain_group->groups.rids = rids;
 
-	domain_group->groups.rids[domain_group->groups.count].rid = rid;
-	domain_group->groups.rids[domain_group->groups.count].attributes = sid->attributes;
+	domain_group->groups.rids[domain_group->groups.count] = (struct samr_RidWithAttribute) {
+		.rid = rid,
+		.attributes = sid->attributes,
+	};
 
 	++domain_group->groups.count;