From: Jelmer Vernooij <jelmer@samba.org>
Date: Tue, 21 Oct 2008 12:57:41 +0000 (+0200)
Subject: Revert "Registry server LDB backend: Don't make copies of the same type"
X-Git-Tag: samba-4.0.0alpha6~777
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d4d4a9da832a4c0c5bb080eb3b7c837fc57da31d;p=thirdparty%2Fsamba.git

Revert "Registry server LDB backend: Don't make copies of the same type"

The original data pointer may go away so we do want to make copies in
this case.

This reverts commit 625359b2e266105022309df8985720108ecd6f67.
---

diff --git a/source4/lib/registry/ldb.c b/source4/lib/registry/ldb.c
index 9c1f59c4df6..018ea86d85d 100644
--- a/source4/lib/registry/ldb.c
+++ b/source4/lib/registry/ldb.c
@@ -72,7 +72,7 @@ static void reg_ldb_unpack_value(TALLOC_CTX *mem_ctx,
 
 	case REG_BINARY:
 		if (val != NULL)
-			*data = *val;
+			*data = data_blob_talloc(mem_ctx, val->data, val->length);
 		else {
 			data->data = NULL;
 			data->length = 0;
@@ -86,7 +86,7 @@ static void reg_ldb_unpack_value(TALLOC_CTX *mem_ctx,
 		break;
 
 	default:
-		*data = *val;
+		*data = data_blob_talloc(mem_ctx, val->data, val->length);
 		break;
 	}
 }