From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Thu, 10 Mar 2022 16:06:59 +0000 (+0100)
Subject: BUG/MEDIUM: quic: qc_prep_app_pkts() retries on qc_build_pkt() failures
X-Git-Tag: v2.6-dev3~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d5066dd9d;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: quic: qc_prep_app_pkts() retries on qc_build_pkt() failures

The "stop_build" label aim is to try to reuse the TX buffer when there is not
enough contiguous room to build a packet. It was defined but not used!
---

diff --git a/src/xprt_quic.c b/src/xprt_quic.c
index 5bf1b2a05e..9b2e38c55b 100644
--- a/src/xprt_quic.c
+++ b/src/xprt_quic.c
@@ -2527,7 +2527,7 @@ static int qc_prep_app_pkts(struct quic_conn *qc, struct qring *qr,
 		case -2:
 			goto err;
 		case -1:
-			goto out;
+			goto stop_build;
 		default:
 			break;
 		}