From: Jim Meyering <jim@meyering.net>
Date: Thu, 26 Sep 2002 08:25:44 +0000 (+0000)
Subject: add a FIXME comment
X-Git-Tag: v4.5.2~78
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d50e1a86b7a8b36f63b5d6bab978b9765ac28f7e;p=thirdparty%2Fcoreutils.git

add a FIXME comment
---

diff --git a/src/csplit.c b/src/csplit.c
index df8546d7a4..2ee32a3e6f 100644
--- a/src/csplit.c
+++ b/src/csplit.c
@@ -1249,6 +1249,9 @@ get_format_width (char **format_ptr)
      allow for enough octal digits to represent the value of LONG_MAX.  */
   count = ((*format_ptr == start)
 	   ? bytes_to_octal_digits[sizeof (long)]
+	   /* FIXME: don't use atoi, it may silently overflow.
+	      Besides, we know the result is non-negative, so shouldn't
+	      need that cast.  */
 	   : (unsigned) atoi (start));
   **format_ptr = ch_save;
   return count;