From: John Ferlan <jferlan@redhat.com>
Date: Tue, 15 Jan 2013 18:12:56 +0000 (-0500)
Subject: rpc: Check and message setsockopt()
X-Git-Tag: v1.0.2-rc1~139
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d514d7773cd7d88041cead6f25cce2055f7c51db;p=thirdparty%2Flibvirt.git

rpc: Check and message setsockopt()

Check status when attempting to set SO_REUSEADDR flag on outgoing connection
On failure, VIR_WARN(), but continue to connect. This code path is on the
sender side where the setting is just a hint and would only take effect if
the sender is overflowed with TCP connections.  Inability to set doesn't mean
failure to establish a connection.
---

diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index 1708d1cd84..1b30985b44 100644
--- a/src/rpc/virnetsocket.c
+++ b/src/rpc/virnetsocket.c
@@ -473,7 +473,9 @@ int virNetSocketNewConnectTCP(const char *nodename,
             goto error;
         }
 
-        setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt));
+        if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt)) < 0) {
+            VIR_WARN("Unable to enable port reuse");
+        }
 
         if (connect(fd, runp->ai_addr, runp->ai_addrlen) >= 0)
             break;