From: Pádraig Brady <P@draigBrady.com>
Date: Wed, 14 Jun 2023 23:53:54 +0000 (+0100)
Subject: doc: mention cksum error fix with cpu feature checks changes
X-Git-Tag: v9.4~104
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d53190ed46a55f599800ebb2d8ddfe38205dbd24;p=thirdparty%2Fcoreutils.git

doc: mention cksum error fix with cpu feature checks changes

* NEWS: Mention the error message to aid those searching
for solutions to the issue, and mention cksum also
as that was confirmed to fix the error with the adjusted
cpu feature detection, as discussed at https://bugs.debian.org/1037264
* src/cksum.c: Cleanup syntax-check failure from previous commit.
---

diff --git a/NEWS b/NEWS
index 3350f98716..5358505499 100644
--- a/NEWS
+++ b/NEWS
@@ -29,7 +29,8 @@ GNU coreutils NEWS                                    -*- outline -*-
   'pr --length=1 --double-space' no longer enters an infinite loop.
   [This bug was present in "the beginning".]
 
-  'wc -l' no longer crashes on x86 Linux kernels that disable XSAVE YMM.
+  'wc -l' and 'cksum' no longer crash with an "Illegal instruction" error
+  on x86 Linux kernels that disable XSAVE YMM.  This was seen on Xen VMs.
   [bug introduced in coreutils-9.0]
 
 ** Changes in behavior
diff --git a/src/cksum.c b/src/cksum.c
index 26bb29bdb6..5b6a59c16e 100644
--- a/src/cksum.c
+++ b/src/cksum.c
@@ -229,9 +229,9 @@ crc_sum_stream (FILE *stream, void *resstream, uintmax_t *length)
   static bool (*cksum_fp) (FILE *, uint_fast32_t *, uintmax_t *);
   if (! cksum_fp)
     cksum_fp = pclmul_supported () ? cksum_pclmul : cksum_slice8;
-#else
+# else
   bool (*cksum_fp) (FILE *, uint_fast32_t *, uintmax_t *) = cksum_slice8;
-#endif
+# endif
 
   if (! cksum_fp (stream, &crc, &total_bytes))
     return -1;