From: Christian Brauner <christianvanbrauner@gmail.com>
Date: Sun, 27 Sep 2015 08:32:28 +0000 (+0200)
Subject: Check return value of snprintf in mount_proc_if_needed()
X-Git-Tag: lxc-2.0.0.beta1~123
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d539a2b2a6a55bd5b530dac78d6d7e7aa5d59090;p=thirdparty%2Flxc.git

Check return value of snprintf in mount_proc_if_needed()

Signed-off-by: Christian Brauner <christianvanbrauner@gmail.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
---

diff --git a/src/lxc/utils.c b/src/lxc/utils.c
index 0b83960b1..8e7fc52f2 100644
--- a/src/lxc/utils.c
+++ b/src/lxc/utils.c
@@ -1431,6 +1431,10 @@ int mount_proc_if_needed(const char *rootfs)
 	mypid = (int)getpid();
 	INFO("I am %d, /proc/self points to '%s'", mypid, link);
 	ret = snprintf(path, MAXPATHLEN, "%s/proc", rootfs);
+	if (ret < 0 || ret >= MAXPATHLEN) {
+		SYSERROR("proc path name too long");
+		return -1;
+	}
 	if (linklen < 0) /* /proc not mounted */
 		goto domount;
 	if (atoi(link) != mypid) {