From: Byron Jones <bjones@mozilla.com>
Date: Mon, 23 Apr 2012 08:54:16 +0000 (+0800)
Subject: Bug 747110: Fix race condition in showdependencygraph.cgi triggering "use of uninitia... 
X-Git-Tag: bugzilla-4.3.2~95
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d550fa977239535afe8bca6acbf3251f5de04b57;p=thirdparty%2Fbugzilla.git

Bug 747110: Fix race condition in showdependencygraph.cgi triggering "use of uninitialized value" warnings.
r=LpSolit, a=LpSolit
---

diff --git a/showdependencygraph.cgi b/showdependencygraph.cgi
index de6caa4592..32abf1747f 100755
--- a/showdependencygraph.cgi
+++ b/showdependencygraph.cgi
@@ -296,7 +296,8 @@ foreach my $f (@files)
     # symlinks), this can't escape to delete anything it shouldn't
     # (unless someone moves the location of $webdotdir, of course)
     trick_taint($f);
-    if (file_mod_time($f) < $since) {
+    my $mtime = file_mod_time($f);
+    if ($mtime && $mtime < $since) {
         unlink $f;
     }
 }