From: Stefan Metzmacher <metze@samba.org>
Date: Sat, 22 Feb 2025 14:58:51 +0000 (+0100)
Subject: s3:testparm: make it clear that 'client use krb5 netlogon' is experimental
X-Git-Tag: samba-4.22.0rc4~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d589ae806b222c4009f12468c1ae133e7403927e;p=thirdparty%2Fsamba.git

s3:testparm: make it clear that 'client use krb5 netlogon' is experimental

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15815

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Feb 24 08:43:55 UTC 2025 on atb-devel-224

(cherry picked from commit 154875244c5a349e04605cad1f66cb26aeaf86d7)
---

diff --git a/source3/utils/testparm.c b/source3/utils/testparm.c
index 55c9bf1e076..a93bc020607 100644
--- a/source3/utils/testparm.c
+++ b/source3/utils/testparm.c
@@ -359,6 +359,7 @@ static int do_global_checks(void)
 	const char **lp_ptr = NULL;
 	const struct loadparm_substitution *lp_sub =
 		loadparm_s3_global_substitution();
+	int ival;
 
 	fprintf(stderr, "\n");
 
@@ -784,6 +785,18 @@ static int do_global_checks(void)
 			"options\n\n");
 	}
 
+	ival = lp__client_use_krb5_netlogon();
+	if (ival > 0) {
+		fprintf(stderr,
+			"ERROR: You have configured "
+			"'client use krb5 netlogon = %s'.\n"
+			"This is experimental in Samba %s "
+			"and should not be used in production!\n\n",
+			ival == Auto ? "auto" : "yes",
+			samba_version_string());
+		ret = 1;
+	}
+
 	if (lp_kerberos_encryption_types() == KERBEROS_ETYPES_LEGACY) {
 		fprintf(stderr,
 			"WARNING: You have configured "