From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 16 Aug 2020 01:15:08 +0000 (-0400)
Subject: set 'p' before using it
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d596bc6547cfda85e175fa1cc21531d7f3ce118a;p=thirdparty%2Ffreeradius-server.git

set 'p' before using it
---

diff --git a/src/protocols/tacacs/encode.c b/src/protocols/tacacs/encode.c
index fa2d9c7acba..c99eff5c474 100644
--- a/src/protocols/tacacs/encode.c
+++ b/src/protocols/tacacs/encode.c
@@ -264,13 +264,13 @@ ssize_t fr_tacacs_encode(uint8_t *buffer, size_t buffer_len, char const *secret,
 			/*
 			 *	Encode 2 mandatory fields.
 			 */
+			p = packet->authen.cont.body;
 			ENCODE_FIELD_STRING16(packet->authen.cont.user_msg_len, attr_tacacs_user_message);
 			ENCODE_FIELD_STRING16(packet->authen.cont.data_len, attr_tacacs_data);
 
 			/*
 			 *	Look at the abort flag after encoding the fields.
 			 */
-			p = packet->authen.cont.body;
 			ENCODE_FIELD_UINT8(packet->authen.cont.flags, attr_tacacs_authentication_flags);
 
 		} else if (packet_is_authen_reply(packet)) {