From: Marek Schimara <Marek.Schimara@bull.net>
Date: Wed, 15 Jun 2016 14:12:47 +0000 (+0200)
Subject: src/rrd_open.c: fix Coverity CID#32402 Unchecked return value from library
X-Git-Tag: v1.7.0~42^2~44
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d59912f2af37d4160da71b73e58d95d313ad7a28;p=thirdparty%2Frrdtool-1.x.git

src/rrd_open.c: fix Coverity CID#32402 Unchecked return value from library

        CWE-252 / https://cwe.mitre.org/data/definitions/252.html
---

diff --git a/src/rrd_open.c b/src/rrd_open.c
index 80a4a795..3bb27266 100644
--- a/src/rrd_open.c
+++ b/src/rrd_open.c
@@ -283,12 +283,18 @@ rrd_file_t *rrd_open(
             goto no_lseek_necessary;        
         }
 #endif
-        lseek(rrd_simple_file->fd, newfile_size - 1, SEEK_SET);
+        if (lseek(rrd_simple_file->fd, newfile_size - 1, SEEK_SET) == -1) {
+            rrd_set_error("lseek '%s': %s", file_name, rrd_strerror(errno));
+            goto out_close;
+        }
         if ( write(rrd_simple_file->fd, "\0", 1) == -1){    /* poke */
             rrd_set_error("write '%s': %s", file_name, rrd_strerror(errno));
             goto out_close;
         }
-        lseek(rrd_simple_file->fd, 0, SEEK_SET);
+        if (lseek(rrd_simple_file->fd, 0, SEEK_SET) == -1){
+            rrd_set_error("lseek '%s': %s", file_name, rrd_strerror(errno));
+            goto out_close;
+        }
     }
     no_lseek_necessary:
 #if !defined(HAVE_MMAP) && defined(HAVE_POSIX_FADVISE)