From: ozppupbg <43532395+ozppupbg@users.noreply.github.com> Date: Mon, 13 Jul 2020 05:04:28 +0000 (+0200) Subject: Fixed EVP_MAC_final argument count in example X-Git-Tag: openssl-3.0.0-alpha7~174 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d5b170a2fcf8b22c67e86a09222dff7ce306c7ad;p=thirdparty%2Fopenssl.git Fixed EVP_MAC_final argument count in example EVP_MAC_final had only three arguments / the buffer/tag size was missing. Fixes #12424 Note, that I didn't try to compile the example to look for other problems. Reviewed-by: Paul Yang Reviewed-by: Tomas Mraz Reviewed-by: Dmitry Belyavskiy (Merged from https://github.com/openssl/openssl/pull/12429) --- diff --git a/doc/man3/EVP_MAC.pod b/doc/man3/EVP_MAC.pod index dc90ee54217..b33af5a670b 100644 --- a/doc/man3/EVP_MAC.pod +++ b/doc/man3/EVP_MAC.pod @@ -322,7 +322,7 @@ EVP_MAC_do_all_provided() returns nothing at all. EVP_MAC_CTX *ctx = NULL; unsigned char buf[4096]; - ssize_t read_l; + size_t read_l; size_t final_l; size_t i; @@ -332,12 +332,12 @@ EVP_MAC_do_all_provided() returns nothing at all. if (cipher != NULL) params[params_n++] = - OSSL_PARAM_construct_utf8_string("cipher", cipher, 0; + OSSL_PARAM_construct_utf8_string("cipher", (char*)cipher, 0); if (digest != NULL) params[params_n++] = - OSSL_PARAM_construct_utf8_string("digest", digest, 0); + OSSL_PARAM_construct_utf8_string("digest", (char*)digest, 0); params[params_n++] = - OSSL_PARAM_construct_octet_string("key", key, strlen(key)); + OSSL_PARAM_construct_octet_string("key", (void*)key, strlen(key)); params[params_n] = OSSL_PARAM_construct_end(); if (mac == NULL @@ -354,7 +354,7 @@ EVP_MAC_do_all_provided() returns nothing at all. goto err; } - if (!EVP_MAC_final(ctx, buf, &final_l)) + if (!EVP_MAC_final(ctx, buf, &final_l, sizeof(buf))) goto err; printf("Result: ");