From: Jason Ish <jason.ish@oisf.net>
Date: Fri, 20 Aug 2021 17:31:03 +0000 (-0600)
Subject: rust(lint): fix some usages of references
X-Git-Tag: suricata-7.0.0-beta1~1516
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d5c0962299e6a2765dd217ccc23a076fb37be9e4;p=thirdparty%2Fsuricata.git

rust(lint): fix some usages of references

- ref is discouraged for top level variables
- the other borrow is not required
---

diff --git a/rust/src/dns/log.rs b/rust/src/dns/log.rs
index 22ffefa521..5c379ff140 100644
--- a/rust/src/dns/log.rs
+++ b/rust/src/dns/log.rs
@@ -742,7 +742,7 @@ fn dns_log_json_failure_v1(r: &DNSResponse, index: usize, flags: u64)
         return Ok(None);
     }
 
-    let ref query = r.queries[index];
+    let query = &r.queries[index];
 
     if !dns_log_rrtype_enabled(query.rrtype, flags) {
         return Ok(None);
diff --git a/rust/src/rdp/util.rs b/rust/src/rdp/util.rs
index 520c3c199d..dfcb8267d2 100644
--- a/rust/src/rdp/util.rs
+++ b/rust/src/rdp/util.rs
@@ -53,7 +53,7 @@ pub fn le_slice_to_string(input: &[u8]) -> Result<String, Box<dyn std::error::Er
 pub fn utf7_slice_to_string(input: &[u8]) -> Result<String, Box<dyn std::error::Error>> {
     let s = match memchr(b'\0', input) {
         Some(end) => &input[..end],
-        None => &input[..],
+        None => input,
     };
     match std::str::from_utf8(s) {
         Ok(s) => Ok(String::from(s)),