From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Sat, 30 Jan 2021 10:25:45 +0000 (+0100)
Subject: cgroups: vet parameters more strictly
X-Git-Tag: lxc-5.0.0~312^2~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d5d4b98e596c707ad58b94e3808e5b7e10772cb9;p=thirdparty%2Flxc.git

cgroups: vet parameters more strictly

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/cgroups/cgfsng.c b/src/lxc/cgroups/cgfsng.c
index 9135d4120..beb277a39 100644
--- a/src/lxc/cgroups/cgfsng.c
+++ b/src/lxc/cgroups/cgfsng.c
@@ -2664,8 +2664,8 @@ __cgfsng_ops static int cgfsng_set(struct cgroup_ops *ops,
 	struct hierarchy *h;
 	int ret = -1;
 
-	if (!ops)
-		return ret_set_errno(-1, ENOENT);
+	if (!ops || !key || !value || !name || !lxcpath)
+		return ret_errno(ENOENT);
 
 	controller = must_copy_string(key);
 	p = strchr(controller, '.');