From: Luca Ceresoli Date: Thu, 23 Apr 2026 11:55:49 +0000 (+0200) Subject: drm/rockchip: rgb: remove now-redundant call to drm_connector_attach_encoder() X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d5d8e04dc0557437b19039206012305166df2bf7;p=thirdparty%2Fkernel%2Flinux.git drm/rockchip: rgb: remove now-redundant call to drm_connector_attach_encoder() drm_connector_attach_encoder() is now called by drm_bridge_connector_init(). Reviewed-by: Dmitry Baryshkov Link: https://patch.msgid.link/20260423115550.444930-6-luca.ceresoli@bootlin.com Signed-off-by: Luca Ceresoli --- diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c index 5c0c6e2cc28dc..add3123e5ce70 100644 --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -162,17 +162,8 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, rgb->encoder.crtc_endpoint_id = endpoint_id; - ret = drm_connector_attach_encoder(connector, encoder); - if (ret < 0) { - DRM_DEV_ERROR(drm_dev->dev, - "failed to attach encoder: %d\n", ret); - goto err_free_connector; - } - return rgb; -err_free_connector: - drm_connector_cleanup(connector); err_free_encoder: drm_encoder_cleanup(encoder); return ERR_PTR(ret);