From: Frank Kardel <kardel@ntp.org>
Date: Sat, 18 Mar 2006 14:08:59 +0000 (+0000)
Subject: refclock_oncore.c:
X-Git-Tag: NTP_4_2_1P10_RC~20
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d5ff276ebadfe08f0b9883d1054c99de8152f297;p=thirdparty%2Fntp.git

refclock_oncore.c:
  mem leakage: free old malloced buffer on errors (Coverity CID 2056 NetBSD Scan 5)

bk: 441c147bwYBxtgAq_KwKWqNdmm5VMg
---

diff --git a/ntpd/refclock_oncore.c b/ntpd/refclock_oncore.c
index fe64d98ec..087427020 100644
--- a/ntpd/refclock_oncore.c
+++ b/ntpd/refclock_oncore.c
@@ -936,6 +936,9 @@ oncore_init_shmem(
 
 	if ((instance->shmemfd = open(instance->shmem_fname, O_RDWR|O_CREAT|O_TRUNC, 0644)) < 0) {
 		record_clock_stats(&(instance->peer->srcadr), "ONCORE: Can't open shmem");
+		if (shmem_old)
+			free(shmem_old);
+
 		return;
 	}
 
@@ -969,6 +972,9 @@ oncore_init_shmem(
 	if (buf == NULL) {
 		record_clock_stats(&(instance->peer->srcadr), "ONCORE: Can't malloc buffer for shmem");
 		close(instance->shmemfd);
+		if (shmem_old)
+			free(shmem_old);
+
 		return;
 	}