From: Maria Matejka <mq@ucw.cz>
Date: Sun, 28 Jan 2024 22:09:47 +0000 (+0100)
Subject: Merge commit '13c6cf8a7430a6b133e46525256eb5554b3f0a2b' into thread-next
X-Git-Tag: v3.0.0~276
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6156334374c416f32ee9ad01ebad3c56941966a;p=thirdparty%2Fbird.git

Merge commit '13c6cf8a7430a6b133e46525256eb5554b3f0a2b' into thread-next
---

d6156334374c416f32ee9ad01ebad3c56941966a
diff --cc proto/bfd/packets.c
index fa8c328f9,e2ec5988f..64e0c5560
--- a/proto/bfd/packets.c
+++ b/proto/bfd/packets.c
@@@ -430,16 -430,17 +430,16 @@@ bfd_open_rx_sk(struct bfd_proto *p, in
    /* TODO: configurable ToS and priority */
    sk->tos = IP_PREC_INTERNET_CONTROL;
    sk->priority = sk_priority_control;
 -  sk->flags = SKF_THREAD | SKF_LADDR_RX | (!multihop ? SKF_TTL_RX : 0);
 +  sk->flags = SKF_LADDR_RX | (!multihop ? SKF_TTL_RX : 0);
  
 -  if (sk_open(sk) < 0)
 +  if (sk_open(sk, p->p.loop) < 0)
      goto err;
  
 -  sk_start(sk);
    return sk;
  
-  err:
+ err:
    sk_log_error(sk, p->p.name);
 -  rfree(sk);
 +  sk_close(sk);
    return NULL;
  }
  
@@@ -461,16 -462,17 +461,16 @@@ bfd_open_rx_sk_bound(struct bfd_proto *
    /* TODO: configurable ToS and priority */
    sk->tos = IP_PREC_INTERNET_CONTROL;
    sk->priority = sk_priority_control;
 -  sk->flags = SKF_THREAD | SKF_BIND | (ifa ? SKF_TTL_RX : 0);
 +  sk->flags = SKF_BIND | (ifa ? SKF_TTL_RX : 0);
  
 -  if (sk_open(sk) < 0)
 +  if (sk_open(sk, p->p.loop) < 0)
      goto err;
  
 -  sk_start(sk);
    return sk;
  
-  err:
+ err:
    sk_log_error(sk, p->p.name);
 -  rfree(sk);
 +  sk_close(sk);
    return NULL;
  }
  
@@@ -492,15 -494,16 +492,15 @@@ bfd_open_tx_sk(struct bfd_proto *p, ip_
    sk->tos = IP_PREC_INTERNET_CONTROL;
    sk->priority = sk_priority_control;
    sk->ttl = ifa ? 255 : -1;
 -  sk->flags = SKF_THREAD | SKF_BIND | SKF_HIGH_PORT;
 +  sk->flags = SKF_BIND | SKF_HIGH_PORT;
  
 -  if (sk_open(sk) < 0)
 +  if (sk_open(sk, p->p.loop) < 0)
      goto err;
  
 -  sk_start(sk);
    return sk;
  
-  err:
+ err:
    sk_log_error(sk, p->p.name);
 -  rfree(sk);
 +  sk_close(sk);
    return NULL;
  }
diff --cc proto/bgp/bgp.c
index 49078520b,cd57c32bc..1c9844387
--- a/proto/bgp/bgp.c
+++ b/proto/bgp/bgp.c
@@@ -1422,11 -1259,11 +1422,11 @@@ bgp_incoming_connection(sock *sk, uint 
  
    if (!acc)
    {
 -    rfree(sk);
 -    return 0;
 +    sk_close(sk);
 +    goto leave;
    }
  
-   hops = p->cf->multihop ? : 1;
+   hops = p->cf->multihop ?: 1;
  
    if (sk_set_ttl(sk, p->cf->ttl_security ? 255 : hops) < 0)
      goto err;
diff --cc proto/rip/rip.c
index 9c03955f6,4bfb57561..bc5bd8b51
--- a/proto/rip/rip.c
+++ b/proto/rip/rip.c
@@@ -77,8 -77,8 +77,9 @@@
   */
  
  #include <stdlib.h>
+ 
  #include "rip.h"
 +#include "lib/macro.h"
  
  
  static inline void rip_lock_neighbor(struct rip_neighbor *n);