From: Joseph Sutton Date: Mon, 7 Aug 2023 04:54:43 +0000 (+1200) Subject: s4:smb_server: Add missing newlines to logging messages X-Git-Tag: tevent-0.16.0~1094 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d61c3684c595a6a10ae03d69644b160357415550;p=thirdparty%2Fsamba.git s4:smb_server: Add missing newlines to logging messages Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- diff --git a/source4/smb_server/smb/negprot.c b/source4/smb_server/smb/negprot.c index cd2451d2e9c..2d78d4e060d 100644 --- a/source4/smb_server/smb/negprot.c +++ b/source4/smb_server/smb/negprot.c @@ -49,13 +49,13 @@ static NTSTATUS get_challenge(struct smbsrv_connection *smb_conn, uint8_t buff[8 smb_conn->lp_ctx, &smb_conn->negotiate.auth_context); if (!NT_STATUS_IS_OK(nt_status)) { - DEBUG(0, ("auth_context_create() returned %s", nt_errstr(nt_status))); + DEBUG(0, ("auth_context_create() returned %s\n", nt_errstr(nt_status))); return nt_status; } nt_status = auth_get_challenge(smb_conn->negotiate.auth_context, buff); if (!NT_STATUS_IS_OK(nt_status)) { - DEBUG(0, ("auth_get_challenge() returned %s", nt_errstr(nt_status))); + DEBUG(0, ("auth_get_challenge() returned %s\n", nt_errstr(nt_status))); return nt_status; } diff --git a/source4/smb_server/smb/sesssetup.c b/source4/smb_server/smb/sesssetup.c index 00d927375a3..69cbdca388c 100644 --- a/source4/smb_server/smb/sesssetup.c +++ b/source4/smb_server/smb/sesssetup.c @@ -519,14 +519,14 @@ static void sesssetup_spnego(struct smbsrv_request *req, union smb_sesssetup *se req); if (!remote_address) { status = NT_STATUS_INTERNAL_ERROR; - DBG_ERR("Failed to obtain remote address"); + DBG_ERR("Failed to obtain remote address\n"); goto failed; } status = gensec_set_remote_address(gensec_ctx, remote_address); if (!NT_STATUS_IS_OK(status)) { - DBG_ERR("Failed to set remote address"); + DBG_ERR("Failed to set remote address\n"); goto failed; } @@ -534,14 +534,14 @@ static void sesssetup_spnego(struct smbsrv_request *req, union smb_sesssetup *se req); if (!local_address) { status = NT_STATUS_INTERNAL_ERROR; - DBG_ERR("Failed to obtain local address"); + DBG_ERR("Failed to obtain local address\n"); goto failed; } status = gensec_set_local_address(gensec_ctx, local_address); if (!NT_STATUS_IS_OK(status)) { - DBG_ERR("Failed to set local address"); + DBG_ERR("Failed to set local address\n"); goto failed; } @@ -549,7 +549,7 @@ static void sesssetup_spnego(struct smbsrv_request *req, union smb_sesssetup *se "SMB"); if (!NT_STATUS_IS_OK(status)) { - DBG_ERR("Failed to set service description"); + DBG_ERR("Failed to set service description\n"); goto failed; } diff --git a/source4/smb_server/smb/trans2.c b/source4/smb_server/smb/trans2.c index fc357ed73f9..1e2d93dc79e 100644 --- a/source4/smb_server/smb/trans2.c +++ b/source4/smb_server/smb/trans2.c @@ -954,8 +954,8 @@ static NTSTATUS trans2_getdfsreferral(struct smbsrv_request *req, } if (outblob.length <= MAX_DFS_RESPONSE) { - DEBUG(10,("DFS: managed to reduce the size of referral initial" - "number of referral %d, actual count: %d", + DEBUG(10,("DFS: managed to reduce the size of referral initial " + "number of referral %d, actual count: %d\n", nb_referrals, r->out.resp->nb_referrals)); ok = true; break; @@ -964,7 +964,7 @@ static NTSTATUS trans2_getdfsreferral(struct smbsrv_request *req, if (!ok && r->out.resp->nb_referrals <= 2) { DEBUG(8, (__location__ "; Not able to fit the domain and realm in DFS a " - " 56K buffer, something must be broken")); + " 56K buffer, something must be broken\n")); talloc_free(r); return NT_STATUS_INTERNAL_ERROR; } diff --git a/source4/smb_server/smb2/receive.c b/source4/smb_server/smb2/receive.c index 2d0c377b13e..7818fdc4826 100644 --- a/source4/smb_server/smb2/receive.c +++ b/source4/smb_server/smb2/receive.c @@ -505,7 +505,7 @@ NTSTATUS smbsrv_recv_smb2_request(void *private_data, DATA_BLOB blob) /* see if its a special NBT packet */ if (CVAL(blob.data,0) != 0) { - DEBUG(2,("Special NBT packet on SMB2 connection")); + DEBUG(2,("Special NBT packet on SMB2 connection\n")); smbsrv_terminate_connection(smb_conn, "Special NBT packet on SMB2 connection"); return NT_STATUS_OK; } diff --git a/source4/smb_server/smb2/sesssetup.c b/source4/smb_server/smb2/sesssetup.c index a8c45608cae..852218ddaea 100644 --- a/source4/smb_server/smb2/sesssetup.c +++ b/source4/smb_server/smb2/sesssetup.c @@ -151,14 +151,14 @@ static void smb2srv_sesssetup_backend(struct smb2srv_request *req, union smb_ses req); if (!remote_address) { status = NT_STATUS_INTERNAL_ERROR; - DBG_ERR("Failed to obtain remote address"); + DBG_ERR("Failed to obtain remote address\n"); goto failed; } status = gensec_set_remote_address(gensec_ctx, remote_address); if (!NT_STATUS_IS_OK(status)) { - DBG_ERR("Failed to set remote address"); + DBG_ERR("Failed to set remote address\n"); goto failed; } @@ -166,14 +166,14 @@ static void smb2srv_sesssetup_backend(struct smb2srv_request *req, union smb_ses req); if (!local_address) { status = NT_STATUS_INTERNAL_ERROR; - DBG_ERR("Failed to obtain local address"); + DBG_ERR("Failed to obtain local address\n"); goto failed; } status = gensec_set_local_address(gensec_ctx, local_address); if (!NT_STATUS_IS_OK(status)) { - DBG_ERR("Failed to set local address"); + DBG_ERR("Failed to set local address\n"); goto failed; } @@ -181,7 +181,7 @@ static void smb2srv_sesssetup_backend(struct smb2srv_request *req, union smb_ses "SMB2"); if (!NT_STATUS_IS_OK(status)) { - DBG_ERR("Failed to set service description"); + DBG_ERR("Failed to set service description\n"); goto failed; }