From: Philippe Waroquiers Date: Tue, 10 Jan 2017 18:07:07 +0000 (+0000) Subject: xtree: CALLED_FLF must be called only up to ips[0] + minor doc update X-Git-Tag: svn/VALGRIND_3_13_0~226 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d62083795cd09077bd2f82b89d10ad7046706efe;p=thirdparty%2Fvalgrind.git xtree: CALLED_FLF must be called only up to ips[0] + minor doc update git-svn-id: svn://svn.valgrind.org/valgrind/trunk@16195 --- diff --git a/coregrind/m_xtree.c b/coregrind/m_xtree.c index c521141633..760cd34a99 100644 --- a/coregrind/m_xtree.c +++ b/coregrind/m_xtree.c @@ -546,8 +546,8 @@ void VG_(XT_callgrind_print) else FP("%d\n", called_linenum); //no self cost. prev_linenum = called_linenum; - CALLED_FLF(ips_idx-1); if (ips_idx >= 1) { + CALLED_FLF(ips_idx-1); FP_pos_str(fp, "cfi", called_filename_nr, called_filename, called_filename_new); FP_pos_str(fp, "cfn", called_fnname_nr, diff --git a/docs/xml/manual-core.xml b/docs/xml/manual-core.xml index 2b4705e3f1..e1a89823da 100644 --- a/docs/xml/manual-core.xml +++ b/docs/xml/manual-core.xml @@ -2858,11 +2858,15 @@ the "Massif Format". -Note that the Callgrind Format is more compact than the Massif Format, - and contains the full data : there is no filtering during file production, - filtering is done by visualisers such as kcachegrind. kcachegrind is - particularly easy to use to analyse big xtree data containing multiple - events counts or resources consumption. +Note that for equivalent information, the Callgrind Format is more compact + than the Massif Format. However, the Callgrind Format always contains the + full data: there is no filtering done during file production, filtering is + done by visualisers such as kcachegrind. kcachegrind is particularly easy to + use to analyse big xtree data containing multiple events counts or resources + consumption. The Massif Format (optionally) only contains a part of the data. + For example, the Massif tool might filter some of the data, according to the + option. + To clarify the xtree concept, the below gives several extracts of the output produced by the following commands: