From: Francis Dupont <fdupont@isc.org>
Date: Tue, 4 Mar 2025 22:10:30 +0000 (+0100)
Subject: [#3758] Removes declineAfterRelease tests
X-Git-Tag: Kea-2.6.2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6269fadd3ded99c7f9d15eb63e1fdc17c4e49bb;p=thirdparty%2Fkea.git

[#3758] Removes declineAfterRelease tests
---

diff --git a/src/bin/dhcp4/tests/decline_unittest.cc b/src/bin/dhcp4/tests/decline_unittest.cc
index 325184fa3b..e632aed2d2 100644
--- a/src/bin/dhcp4/tests/decline_unittest.cc
+++ b/src/bin/dhcp4/tests/decline_unittest.cc
@@ -364,31 +364,6 @@ TEST_F(DeclineTest, declineNonMatchingIPAddress) {
     EXPECT_EQ(Lease::STATE_DEFAULT, lease->state_);
 }
 
-// Test that the released lease cannot be declined.
-TEST_F(DeclineTest, declineAfterRelease) {
-    Dhcp4Client client(Dhcp4Client::SELECTING);
-    // Configure DHCP server.
-    configure(DECLINE_CONFIGS[0], *client.getServer(), true, true, true, false, LEASE_AFFINITY_ENABLED);
-    // Perform 4-way exchange to obtain a new lease.
-    acquireLease(client);
-
-    // Remember the acquired address.
-    IOAddress leased_address = client.config_.lease_.addr_;
-
-    // Release the acquired lease.
-    client.doRelease();
-
-    // Try to decline the released address.
-    client.config_.lease_.addr_ = leased_address;
-    ASSERT_NO_THROW(client.doDecline());
-
-    // The address should not be declined. It should still be in the
-    // released state.
-    Lease4Ptr lease = LeaseMgrFactory::instance().getLease4(leased_address);
-    ASSERT_TRUE(lease);
-    EXPECT_EQ(Lease::STATE_RELEASED, lease->state_);
-}
-
 // Test that the expired lease cannot be declined.
 TEST_F(DeclineTest, declineAfterExpire) {
     Dhcp4Client client(Dhcp4Client::SELECTING);
diff --git a/src/bin/dhcp6/tests/decline_unittest.cc b/src/bin/dhcp6/tests/decline_unittest.cc
index e5c28ee0d3..1d2c0ed1da 100644
--- a/src/bin/dhcp6/tests/decline_unittest.cc
+++ b/src/bin/dhcp6/tests/decline_unittest.cc
@@ -329,35 +329,6 @@ TEST_F(DeclineTest, noIAs) {
                       NO_IA, SHOULD_FAIL);
 }
 
-// Test that the released lease cannot be declined.
-TEST_F(DeclineTest, declineAfterRelease) {
-    Dhcp6Client client;
-    uint32_t iaid = 1;
-    client.requestAddress(iaid);
-
-    // Configure DHCP server.
-    configure(DECLINE_CONFIGS[0], *client.getServer());
-    // Perform 4-way exchange to obtain a new lease.
-    client.doSARR();
-    auto leases = client.getLeasesByType(Lease::TYPE_NA);
-    ASSERT_EQ(1, leases.size());
-    EXPECT_EQ(STATUS_Success, client.getStatusCode(iaid));
-
-    // Release the acquired lease.
-    auto lease = LeaseMgrFactory::instance().getLease6(Lease::TYPE_NA, leases[0].addr_);
-    lease->state_ = Lease::STATE_RELEASED;
-    LeaseMgrFactory::instance().updateLease6(lease);
-
-    // Try to decline the released address.
-    ASSERT_NO_THROW(client.doDecline());
-
-    // The address should not be declined. It should still be in the
-    // released state.
-    lease = LeaseMgrFactory::instance().getLease6(Lease::TYPE_NA, lease->addr_);
-    ASSERT_TRUE(lease);
-    EXPECT_EQ(Lease::STATE_RELEASED, lease->state_);
-}
-
 // Test that the released lease cannot be declined.
 TEST_F(DeclineTest, declineAfterExpire) {
     Dhcp6Client client;