From: Jouni Malinen <j@w1.fi>
Date: Sun, 5 Aug 2012 17:58:44 +0000 (+0300)
Subject: wpa_cli: Fix resource leak on attach failures in interactive mode
X-Git-Tag: hostap_2_0~485
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d62aaa7de1acb6039af0e66ade33781bc543d19d;p=thirdparty%2Fhostap.git

wpa_cli: Fix resource leak on attach failures in interactive mode

When starting interactive mode, wpa_cli is trying to attach the
monitor connection. If that fails, the operation is retried, but
this was done without freeing all the resources that could have
been allocated (mainly, the command connection).

Signed-hostap: Jouni Malinen <j@w1.fi>
---

diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c
index b220443be..28961fe17 100644
--- a/wpa_supplicant/wpa_cli.c
+++ b/wpa_supplicant/wpa_cli.c
@@ -94,6 +94,7 @@ static DEFINE_DL_LIST(p2p_groups); /* struct cli_txt_entry */
 
 static void print_help(void);
 static void wpa_cli_mon_receive(int sock, void *eloop_ctx, void *sock_ctx);
+static void wpa_cli_close_connection(void);
 
 
 static void usage(void)
@@ -361,6 +362,7 @@ static int wpa_cli_open_connection(const char *ifname, int attach)
 		} else {
 			printf("Warning: Failed to attach to "
 			       "wpa_supplicant.\n");
+			wpa_cli_close_connection();
 			return -1;
 		}
 	}