From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Fri, 27 Jun 2025 14:13:03 +0000 (+0200)
Subject: shared/bus-unit-util: add helper for Listen property
X-Git-Tag: v258-rc1~183^2~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d661a540a3b8552e1f7ea93ad29d961a00eb16fd;p=thirdparty%2Fsystemd.git

shared/bus-unit-util: add helper for Listen property
---

diff --git a/src/shared/bus-unit-util.c b/src/shared/bus-unit-util.c
index bf204e6d78f..62df0f5e36d 100644
--- a/src/shared/bus-unit-util.c
+++ b/src/shared/bus-unit-util.c
@@ -2169,6 +2169,21 @@ static int bus_append_exit_status(sd_bus_message *m, const char *field, const ch
         return 1;
 }
 
+static int bus_append_listen(sd_bus_message *m, const char *field, const char *eq) {
+        int r;
+
+        const char *p = ASSERT_PTR(startswith(field, "Listen"));
+
+        if (isempty(eq))
+                r = sd_bus_message_append(m, "(sv)", "Listen", "a(ss)", 0);
+        else
+                r = sd_bus_message_append(m, "(sv)", "Listen", "a(ss)", 1, p, eq);
+        if (r < 0)
+                return bus_log_create_error(r);
+
+        return 1;
+}
+
 static int bus_append_cgroup_property(sd_bus_message *m, const char *field, const char *eq) {
         if (STR_IN_SET(field, "DevicePolicy",
                               "Slice",
@@ -2698,8 +2713,6 @@ static int bus_append_service_property(sd_bus_message *m, const char *field, con
 }
 
 static int bus_append_socket_property(sd_bus_message *m, const char *field, const char *eq) {
-        int r;
-
         if (STR_IN_SET(field, "Accept",
                               "FlushPending",
                               "Writable",
@@ -2789,16 +2802,8 @@ static int bus_append_socket_property(sd_bus_message *m, const char *field, cons
                               "ListenSpecial",
                               "ListenMessageQueue",
                               "ListenFIFO",
-                              "ListenUSBFunction")) {
-                if (isempty(eq))
-                        r = sd_bus_message_append(m, "(sv)", "Listen", "a(ss)", 0);
-                else
-                        r = sd_bus_message_append(m, "(sv)", "Listen", "a(ss)", 1, field + STRLEN("Listen"), eq);
-                if (r < 0)
-                        return bus_log_create_error(r);
-
-                return 1;
-        }
+                              "ListenUSBFunction"))
+                return bus_append_listen(m, field, eq);
 
         return 0;
 }