From: Christopher Faulet <cfaulet@haproxy.com>
Date: Mon, 15 Dec 2025 07:01:20 +0000 (+0100)
Subject: CLEANUP: tcpcheck: Remove useless test on the xprt used for healthchecks
X-Git-Tag: v3.4-dev2~64
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6b1d5f6e9a0577e06fc17e9162db98b042e601b;p=thirdparty%2Fhaproxy.git

CLEANUP: tcpcheck: Remove useless test on the xprt used for healthchecks

The xprt used to perform a healthcheck is always defined and cannot be NULL.
So there is no reason to test it. It could lead to wrong assumptions later
in the code.

This patch should fix a Coverity report from #3213.
---

diff --git a/src/tcpcheck.c b/src/tcpcheck.c
index 28cdd94f2..f307c814b 100644
--- a/src/tcpcheck.c
+++ b/src/tcpcheck.c
@@ -1462,7 +1462,7 @@ enum tcpcheck_eval_ret tcpcheck_eval_connect(struct check *check, struct tcpchec
 		: ((connect->options & TCPCHK_OPT_DEFAULT_CONNECT) ? check->xprt : xprt_get(XPRT_RAW)));
 
 #ifdef USE_OPENSSL
-	if (xprt && xprt->get_ssl_sock_ctx) {
+	if (xprt->get_ssl_sock_ctx) {
 		if (connect->sni)
 			sni = ist(connect->sni);
 		else if ((connect->options & TCPCHK_OPT_DEFAULT_CONNECT) && s && s->check.sni)