From: Collin Funk <collin.funk1@gmail.com>
Date: Sun, 15 Feb 2026 23:18:37 +0000 (-0800)
Subject: parse-datetime: Prefer ckd_add to checking overflow by hand.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6b8c8a05ec18d4294f0dceb4bd655cf5665c975;p=thirdparty%2Fgnulib.git

parse-datetime: Prefer ckd_add to checking overflow by hand.

* lib/parse-datetime.y (time_overflow): Use ckd_add to check for
overflow.
---

diff --git a/ChangeLog b/ChangeLog
index 85d0713c16..b1725725ff 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2026-02-15  Collin Funk  <collin.funk1@gmail.com>
+
+	parse-datetime: Prefer ckd_add to checking overflow by hand.
+	* lib/parse-datetime.y (time_overflow): Use ckd_add to check for
+	overflow.
+
 2026-02-14  Paul Eggert  <eggert@cs.ucla.edu>
 
 	fchownat: port to IBM XL C for AIX 16.1
diff --git a/lib/parse-datetime.y b/lib/parse-datetime.y
index 8d396b1273..6732bf1520 100644
--- a/lib/parse-datetime.y
+++ b/lib/parse-datetime.y
@@ -99,8 +99,8 @@ static_assert (TYPE_MAXIMUM (time_t) <= INTMAX_MAX);
 static bool
 time_overflow (intmax_t n)
 {
-  return ! ((TYPE_SIGNED (time_t) ? TYPE_MINIMUM (time_t) <= n : 0 <= n)
-            && n <= TYPE_MAXIMUM (time_t));
+  time_t t;
+  return ckd_add (&t, n, 0);
 }
 
 /* Convert a possibly-signed character to an unsigned character.  This is