From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 30 Oct 2019 20:08:49 +0000 (-0400)
Subject: check length before dereferencing it
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6bfb5cf03a9f5891ec619082bc08c42f2413c0d;p=thirdparty%2Ffreeradius-server.git

check length before dereferencing it
---

diff --git a/src/protocols/dhcpv4/packet.c b/src/protocols/dhcpv4/packet.c
index 89923311f5c..ae2e116021e 100644
--- a/src/protocols/dhcpv4/packet.c
+++ b/src/protocols/dhcpv4/packet.c
@@ -92,7 +92,7 @@ uint8_t const *fr_dhcpv4_packet_get_option(dhcp_packet_t const *packet, size_t p
 
 		if (data[0] == da->attr) return data;
 
-		if (data[0] == 52) { /* overload sname and/or file */
+		if ((data[0] == 52) && (data[1] > 0)) { /* overload sname and/or file */
 			overload = data[2];
 		}