From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Tue, 2 May 2023 12:13:16 +0000 (+0200)
Subject: add comments
X-Git-Tag: auth-4.8.0-beta1~1^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6c032385b7325795fc0a584991018d4017c69fc;p=thirdparty%2Fpdns.git

add comments
---

diff --git a/ext/lmdb-safe/lmdb-typed.hh b/ext/lmdb-safe/lmdb-typed.hh
index a48c3af010..ad5bb07c8a 100644
--- a/ext/lmdb-safe/lmdb-typed.hh
+++ b/ext/lmdb-safe/lmdb-typed.hh
@@ -310,6 +310,7 @@ public:
       // auto range = prefix_range<N>(key);
       LMDBIDvec ids;
 
+      // because we know we only want one item, pass onlyOldest=true to consistently get the same one out of a set of duplicates
       get_multi<N>(key, ids, true);
 
       if (ids.size() == 0) {
diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index 88cde13a1e..219521978f 100644
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1679,6 +1679,7 @@ void LMDBBackend::getAllDomainsFiltered(vector<DomainInfo>* domains, const std::
     for (const auto& zone : dups) {
       DomainInfo di;
 
+      // this get grabs the oldest item if there are duplicates
       if (!(di.id = txn.get<0>(zone, di))) {
         continue;
       }