From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Sat, 27 Apr 2019 18:21:44 +0000 (+0200)
Subject: girwriter: Don't write "property" attribute for non-gobject properties
X-Git-Tag: 0.36.20~33
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6e1f49d6a267eea17e295aa45e32f72e47834eb;p=thirdparty%2Fvala.git

girwriter: Don't write "property" attribute for non-gobject properties
---

diff --git a/codegen/valagirwriter.vala b/codegen/valagirwriter.vala
index 17db20645..3696d7d14 100644
--- a/codegen/valagirwriter.vala
+++ b/codegen/valagirwriter.vala
@@ -1145,32 +1145,34 @@ public class Vala.GIRWriter : CodeVisitor {
 			return;
 		}
 
-		write_indent ();
-		buffer.append_printf ("<property name=\"%s\"", prop.name.replace ("_", "-"));
-		if (prop.get_accessor == null) {
-			buffer.append_printf (" readable=\"0\"");
-		}
-		if (prop.set_accessor != null) {
-			buffer.append_printf (" writable=\"1\"");
-			if (prop.set_accessor.construction) {
-				if (!prop.set_accessor.writable) {
-					buffer.append_printf (" construct-only=\"1\"");
-				} else {
-					buffer.append_printf (" construct=\"1\"");
+		if (((CCodeBaseModule) context.codegen).is_gobject_property (prop)) {
+			write_indent ();
+			buffer.append_printf ("<property name=\"%s\"", prop.name.replace ("_", "-"));
+			if (prop.get_accessor == null) {
+				buffer.append_printf (" readable=\"0\"");
+			}
+			if (prop.set_accessor != null) {
+				buffer.append_printf (" writable=\"1\"");
+				if (prop.set_accessor.construction) {
+					if (!prop.set_accessor.writable) {
+						buffer.append_printf (" construct-only=\"1\"");
+					} else {
+						buffer.append_printf (" construct=\"1\"");
+					}
 				}
 			}
-		}
-		write_symbol_attributes (prop);
-		buffer.append_printf (">\n");
-		indent++;
+			write_symbol_attributes (prop);
+			buffer.append_printf (">\n");
+			indent++;
 
-		write_doc (get_property_comment (prop));
+			write_doc (get_property_comment (prop));
 
-		write_type (prop.property_type);
+			write_type (prop.property_type);
 
-		indent--;
-		write_indent ();
-		buffer.append_printf ("</property>\n");
+			indent--;
+			write_indent ();
+			buffer.append_printf ("</property>\n");
+		}
 
 		if (prop.get_accessor != null) {
 			var m = prop.get_accessor.get_method ();