From: Niels Möller <nisse@lysator.liu.se>
Date: Fri, 6 Nov 2020 18:46:32 +0000 (+0100)
Subject: Delete unneeded copy in ecc_add_jja.
X-Git-Tag: nettle_3.7rc1~52^2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d6f3118575ad48fbae0e29d8e88280e4d6b7210e;p=thirdparty%2Fnettle.git

Delete unneeded copy in ecc_add_jja.
---

diff --git a/ChangeLog b/ChangeLog
index 4409d6f9..34089357 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2020-11-06  Niels Möller  <nisse@lysator.liu.se>
+
+	* ecc-add-jja.c (ecc_add_jja): Delete an unneeded copy.
+
 2020-11-05  Niels Möller  <nisse@lysator.liu.se>
 
 	* ecc-dup-jj.c (ecc_dup_jj): Reduce scratch need.
diff --git a/ecc-add-jja.c b/ecc-add-jja.c
index a8f92fe6..a79f995e 100644
--- a/ecc-add-jja.c
+++ b/ecc-add-jja.c
@@ -119,7 +119,6 @@ ecc_add_jja (const struct ecc_curve *ecc,
   /* y_3, use (h, hh) as sqratch */
   ecc_mod_mul (&ecc->p, h, y1, j, h); /* frees j */
   ecc_mod_sub (&ecc->p, r + ecc->p.size, v, r);
-  ecc_mod_mul (&ecc->p, j, r + ecc->p.size, w, j);
-  ecc_mod_submul_1 (&ecc->p, j, h, 2);
-  mpn_copyi (r + ecc->p.size, j, ecc->p.size);
+  ecc_mod_mul (&ecc->p, r + ecc->p.size, r + ecc->p.size, w, j);
+  ecc_mod_submul_1 (&ecc->p, r + ecc->p.size, h, 2);
 }