From: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
Date: Tue, 31 Aug 2021 10:29:01 +0000 (-0300)
Subject: Add support for comma as a completion word.
X-Git-Tag: lxc-5.0.0~91^2~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d72a39a52892719d150c957b2ce6040ca94db465;p=thirdparty%2Flxc.git

Add support for comma as a completion word.

For `lxc-ls --groups` and `lxc-autostart --groups`.
Support leading comma, trailing comma, embedded double comma.

Signed-off-by: Edênis Freindorfer Azevedo <edenisfa@gmail.com>
---

diff --git a/config/bash/lxc.in b/config/bash/lxc.in
index 71433aa30..8eb2df3f3 100644
--- a/config/bash/lxc.in
+++ b/config/bash/lxc.in
@@ -219,7 +219,13 @@ __lxc_piped_args() {
                 prefix=$(__lxc_concat_array_sep "${sep}" "${current[@]}")
                 for comp in "${completion[@]}"; do
                     [[ "${comp}" == "${lastword}" ]] && continue
-                    extcompletion+=("\"${prefix}${comp}\"")
+                    if [[ "${comp}" != "${sep}" ]]; then
+                        extcompletion+=("\"${prefix}${comp}\"")
+                    else
+                        # Trailing sep.
+                        extcompletion+=("\"${prefix}\"")
+                        [[ "${#completion[@]}" -gt 2 ]] && extcompletion+=("\"${prefix}${comp}\"")
+                    fi
                 done
             fi
         fi
@@ -329,8 +335,7 @@ _lxc_autostart() {
             return
             ;;
         --groups | -g )
-            # @TODO: add NULL group as a leading comma, trailing comma, embedded double comma.
-            __lxc_piped_args "${cur}" ',' $( __lxc_groups )
+            __lxc_piped_args "${cur}" ',' $( __lxc_groups ) ','
             return
             ;;
     esac
@@ -754,8 +759,7 @@ _lxc_ls() {
             return
             ;;
         --groups | -g )
-            # @TODO: add NULL group as a leading comma, trailing comma, embedded double comma.
-            __lxc_piped_args "${cur}" ',' $( __lxc_groups )
+            __lxc_piped_args "${cur}" ',' $( __lxc_groups ) ','
             return
             ;;
         --nesting )