From: Matthijs Mekking <matthijs@isc.org>
Date: Mon, 3 Jun 2024 05:56:21 +0000 (+0200)
Subject: Log error when update fails
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d72adf4b927d83a2a0ff8e431b911ec1df7aeb88;p=thirdparty%2Fbind9.git

Log error when update fails

The new "too many records" error can make an update fail without the
error being logged. This commit fixes that.

(cherry picked from commit 558923e5405894cf976d102f0d246a28bdbb400c)
---

diff --git a/lib/ns/update.c b/lib/ns/update.c
index 4e51cdcb774..d9cea2c4c6a 100644
--- a/lib/ns/update.c
+++ b/lib/ns/update.c
@@ -3136,9 +3136,18 @@ update_action(isc_task_t *task, isc_event_t *event) {
 						dns_diff_clear(&ctx.add_diff);
 						goto failure;
 					}
-					CHECK(update_one_rr(db, ver, &diff,
-							    DNS_DIFFOP_ADD,
-							    name, ttl, &rdata));
+					result = update_one_rr(
+						db, ver, &diff, DNS_DIFFOP_ADD,
+						name, ttl, &rdata);
+					if (result != ISC_R_SUCCESS) {
+						update_log(client, zone,
+							   LOGLEVEL_PROTOCOL,
+							   "adding an RR "
+							   "failed: %s",
+							   isc_result_totext(
+								   result));
+						goto failure;
+					}
 				}
 			}
 		} else if (update_class == dns_rdataclass_any) {