From: mkanat%bugzilla.org <>
Date: Wed, 17 May 2006 05:07:07 +0000 (+0000)
Subject: Bug 337701: 012throwables.t doesn't recognize that certain errors are AUTH_ERROR... 
X-Git-Tag: bugzilla-2.23.2~167
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d72d5a40777fa7e75aeeb145e8fb8a65b97de291;p=thirdparty%2Fbugzilla.git

Bug 337701: 012throwables.t doesn't recognize that certain errors are AUTH_ERROR codes
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave
---

diff --git a/t/012throwables.t b/t/012throwables.t
index 2c7a5998b4..8bc749686d 100644
--- a/t/012throwables.t
+++ b/t/012throwables.t
@@ -113,9 +113,18 @@ foreach my $file (keys %test_modules) {
         last if $line =~ /^__END__/; # skip the POD (at least in
                                         # Bugzilla/Error.pm)
         $lineno++;
-        if ($line =~ /^[^#]*Throw(Code|User)Error\s*\(\s*["'](.*?)['"]/) {
-            my $errtype = lc($1);
-            my $errtag = $2;
+        if ($line =~
+/^[^#]*(Throw(Code|User)Error|error\s+=>)\s*\(?\s*["'](.*?)['"]/) {
+            my $errtype;
+            # If it's a normal ThrowCode/UserError
+            if ($2) {
+                $errtype = lc($2);
+            }
+            # If it's an AUTH_ERROR tag
+            else {
+                $errtype = 'code';
+            }
+            my $errtag = $3;
             push @{$Errors{$errtype}{$errtag}{used_in}{$file}}, $lineno;
         }
     }