From: Yehor Velykozhon -X (yvelykoz - SOFTSERVE INC at Cisco) <yvelykoz@cisco.com>
Date: Thu, 26 Oct 2023 15:11:05 +0000 (+0000)
Subject: Pull request #4068: http_inspect: add correct handling of configuration error
X-Git-Tag: 3.1.74.0~11
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d72efa2d5b1d0af1399aaaac691a64759b90bafa;p=thirdparty%2Fsnort3.git

Pull request #4068: http_inspect: add correct handling of configuration error

Merge in SNORT/snort3 from ~YVELYKOZ/snort3:http_param_fix to master

Squashed commit of the following:

commit 2a15f0c5742bd014c9152620b68158db81237637
Author: Yehor Velykozhon <yvelykoz@cisco.com>
Date:   Wed Oct 25 14:02:35 2023 +0300

    http_inspect: add correct handling of configuration error
---

diff --git a/src/service_inspectors/http_inspect/ips_http_param.cc b/src/service_inspectors/http_inspect/ips_http_param.cc
index 55c2f7185..140441942 100644
--- a/src/service_inspectors/http_inspect/ips_http_param.cc
+++ b/src/service_inspectors/http_inspect/ips_http_param.cc
@@ -80,7 +80,11 @@ uint32_t HttpParamIpsOption::hash() const
 bool HttpParamRuleOptModule::end(const char*, int, SnortConfig*)
 {
     if (param.length() == 0)
+    {
         ParseError("Specify parameter name");
+        return false;
+    }
+
     return true;
 }