From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Thu, 1 Aug 2024 13:16:15 +0000 (-0600)
Subject: Close sqlite handle when we fail to pre-poopulate the database.  Closes #5392
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d736cfa0d954e85a5616e95e55ac53ebd3686a56;p=thirdparty%2Ffreeradius-server.git

Close sqlite handle when we fail to pre-poopulate the database.  Closes #5392
---

diff --git a/src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c b/src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c
index 658470dc1cd..1ef18a88155 100644
--- a/src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c
+++ b/src/modules/rlm_sql/drivers/rlm_sql_sqlite/rlm_sql_sqlite.c
@@ -771,7 +771,10 @@ static int mod_instantiate(module_inst_ctx_t const *mctx)
 			if (!p) continue;
 
 			ret = sql_loadfile(mctx->mi->conf, db, p);
-			if (ret < 0) goto unlink;
+			if (ret < 0) {
+				(void) sqlite3_close(db);
+				goto unlink;
+			}
 		}
 
 		status = sqlite3_close(db);