From: Serge Hallyn <serge.hallyn@ubuntu.com>
Date: Wed, 24 Jun 2015 18:07:05 +0000 (-0500)
Subject: lxc_user_nic: free_groupnames: fix
X-Git-Tag: lxc-2.0.0.beta1~237
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d791668b9adf7a889a4ccec9069af5baaa66189d;p=thirdparty%2Flxc.git

lxc_user_nic: free_groupnames: fix

lxc_user_nic was segfaulting:
lxc-user-nic[9761]: segfault at 29 ip 00007f3fb2346872 sp 00007ffdd17b2dd0 error 4 in libc-2.21.so[7f3fb22c2000+1c0000

This patch fixes it.

Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
---

diff --git a/src/lxc/lxc_user_nic.c b/src/lxc/lxc_user_nic.c
index 2f1045133..af7f8b459 100644
--- a/src/lxc/lxc_user_nic.c
+++ b/src/lxc/lxc_user_nic.c
@@ -99,9 +99,11 @@ static char *get_username(void)
 
 static void free_groupnames(char **groupnames)
 {
-	char **group;
-	for (group=groupnames; group != NULL; group++)
-		free(*group);
+	int i;
+	if (!groupnames)
+		return;
+	for (i = 0; groupnames[i]; i++)
+		free(groupnames[i]);
 	free(groupnames);
 }