From: Gaëtan de Menten Date: Wed, 4 Nov 2009 13:19:47 +0000 (+0000) Subject: Using generators for small lists is highly inefficient. This change shoves X-Git-Tag: rel_0_6beta1~188 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d79d48ca55a3576723cd3bdde05b426de07c1e69;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git Using generators for small lists is highly inefficient. This change shoves 6% of total time for large ORM queries. Not bad for a 2 characters change :) --- diff --git a/lib/sqlalchemy/orm/mapper.py b/lib/sqlalchemy/orm/mapper.py index 6bc55c8315..146c4d6737 100644 --- a/lib/sqlalchemy/orm/mapper.py +++ b/lib/sqlalchemy/orm/mapper.py @@ -1583,7 +1583,7 @@ class Mapper(object): identity_class = self._identity_class def identity_key(row): - return (identity_class, tuple(row[column] for column in pk_cols)) + return (identity_class, tuple([row[column] for column in pk_cols])) new_populators = [] existing_populators = []