From: Bob Halley Date: Tue, 20 Feb 2018 20:08:47 +0000 (-0800) Subject: delint X-Git-Tag: v1.16.0~30 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d7ab9b5d52c16fea449ebcde8010d3c62cc9d632;p=thirdparty%2Fdnspython.git delint --- diff --git a/dns/zone.py b/dns/zone.py index 657c2098..37f23d3d 100644 --- a/dns/zone.py +++ b/dns/zone.py @@ -155,24 +155,24 @@ class Zone(object): def iterkeys(self): if PY3: - return self.nodes.keys() + return self.nodes.keys() # pylint: disable=dict-keys-not-iterating else: return self.nodes.iterkeys() # pylint: disable=dict-iter-method def keys(self): - return self.nodes.keys() + return self.nodes.keys() # pylint: disable=dict-keys-not-iterating def itervalues(self): if PY3: - return self.nodes.values() + return self.nodes.values() # pylint: disable=dict-values-not-iterating else: return self.nodes.itervalues() # pylint: disable=dict-iter-method def values(self): - return self.nodes.values() + return self.nodes.values() # pylint: disable=dict-values-not-iterating def items(self): - return self.nodes.items() + return self.nodes.items() # pylint: disable=dict-items-not-iterating iteritems = items diff --git a/examples/reverse.py b/examples/reverse.py index b0a867d2..b84017fd 100755 --- a/examples/reverse.py +++ b/examples/reverse.py @@ -34,9 +34,7 @@ for filename in sys.argv[1:]: except KeyError: reverse_map[rdata.address] = [name.to_text()] -keys = reverse_map.keys() -keys.sort(key=dns.ipv4.inet_aton) -for k in keys: +for k in sorted(reverse_map.keys(), key=dns.ipv4.inet_aton): v = reverse_map[k] v.sort() print(k, v) diff --git a/examples/xfr.py b/examples/xfr.py index a7c2bb95..ec24b42d 100755 --- a/examples/xfr.py +++ b/examples/xfr.py @@ -10,7 +10,5 @@ soa_answer = dns.resolver.query('dnspython.org', 'SOA') master_answer = dns.resolver.query(soa_answer[0].mname, 'A') z = dns.zone.from_xfr(dns.query.xfr(master_answer[0].address, 'dnspython.org')) -names = z.nodes.keys() -names.sort() -for n in names: +for n in sorted(z.nodes.keys()): print(z[n].to_text(n)) diff --git a/pylintrc b/pylintrc index bdb82db0..2a7f7187 100644 --- a/pylintrc +++ b/pylintrc @@ -40,6 +40,7 @@ disable= wrong-import-position, len-as-condition, eq-without-hash, + next-method-defined, [REPORTS]