From: Bruce Ashfield Date: Sat, 16 Nov 2013 06:17:24 +0000 (-0500) Subject: kernel.bbclass: fix hardlink test X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d7ccfc7605f1eb61511b1b2b8db4ac689ce6a468;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git kernel.bbclass: fix hardlink test The commit [kernel.bbclass: test for hardlinks before installing] doesn't work on all build machines without a space between the ! and the test for hardlink equivalance. The build continues, while the test fails and no copy is made into the sysroot. Eventually tasks like build_hdimg will fail with the missing kernel with the root cause being less than obvious. (From OE-Core rev: 0704648e9dfd2897f6f54773a0e7d2762117970c) Signed-off-by: Bruce Ashfield Signed-off-by: Richard Purdie --- diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index 624b15101ed..6959aa16140 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -248,7 +248,7 @@ kernel_do_install() { # Test to ensure that the output file and image type are not actually # the same file. If hardlinking is used, they will be the same, and there's # no need to install. - ![ ${KERNEL_OUTPUT} -ef $kerneldir/${KERNEL_IMAGETYPE} ] && install -m 0644 ${KERNEL_OUTPUT} $kerneldir/${KERNEL_IMAGETYPE} + ! [ ${KERNEL_OUTPUT} -ef $kerneldir/${KERNEL_IMAGETYPE} ] && install -m 0644 ${KERNEL_OUTPUT} $kerneldir/${KERNEL_IMAGETYPE} install -m 0644 System.map $kerneldir/System.map-${KERNEL_VERSION} # Dummy Makefile so the clean below works