From: Douglas Bagnall Date: Thu, 2 May 2024 23:29:31 +0000 (+1200) Subject: pytest: sid_strings: Samba DN object refuses sub-auth overflow X-Git-Tag: tdb-1.4.11~819 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d801ed8b11125527b0b8193c8d0e430b5fb2c3a7;p=thirdparty%2Fsamba.git pytest: sid_strings: Samba DN object refuses sub-auth overflow We were mistakenly asserting something that did not happen with Windows, because Samba already won't parse the DN string. BUG: https://bugzilla.samba.org/show_bug.cgi?id=10763 Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- diff --git a/python/samba/tests/sid_strings.py b/python/samba/tests/sid_strings.py index 1b720356d83..fbeb0a94077 100644 --- a/python/samba/tests/sid_strings.py +++ b/python/samba/tests/sid_strings.py @@ -491,9 +491,9 @@ class SidStringsAsDnSearchWithDnObject(SidStringBase): 'S-1-0x05-32-579': (None, None), 'S-1-0x5-0x20-0x221': (None, None), 'S-1-0x50000000-32-579': (None, ldb.ERR_NO_SUCH_OBJECT), - 'S-1-0x500000000-0x500000000-579': (None, ldb.ERR_NO_SUCH_OBJECT), + 'S-1-0x500000000-0x500000000-579': ('parse error', None), 'S-1-0x500000000-32-579': (None, ldb.ERR_NO_SUCH_OBJECT), - 'S-1-0xABcDef123-0xABCDef123-579': (None, ldb.ERR_NO_SUCH_OBJECT), + 'S-1-0xABcDef123-0xABCDef123-579': ('parse error', None), 'S-1-1-1-1-1-1-1': (None, ldb.ERR_NO_SUCH_OBJECT), 'S-1-21474836480-32-579': (None, ldb.ERR_NO_SUCH_OBJECT), 'S-1-22': (None, ldb.ERR_NO_SUCH_OBJECT), diff --git a/selftest/knownfail.d/sid-strings b/selftest/knownfail.d/sid-strings index 7b2a779ce70..36b73ca98b7 100644 --- a/selftest/knownfail.d/sid-strings +++ b/selftest/knownfail.d/sid-strings @@ -58,8 +58,6 @@ ^samba.tests.sid_strings.+.SidStringsAsDnInSearchBase.test_sid_string_S-2-5-32-579.ad_dc ^samba.tests.sid_strings.+.SidStringsAsDnSearchWithDnObject.test_sid_string_S-0-5-32-579.ad_dc ^samba.tests.sid_strings.+.SidStringsAsDnSearchWithDnObject.test_sid_string_S-1-0x05-32-579.ad_dc -^samba.tests.sid_strings.+.SidStringsAsDnSearchWithDnObject.test_sid_string_S-1-0x500000000-0x500000000-579.ad_dc -^samba.tests.sid_strings.+.SidStringsAsDnSearchWithDnObject.test_sid_string_S-1-0xABcDef123-0xABCDef123-579.ad_dc ^samba.tests.sid_strings.+.SidStringsAsDnSearchWithDnObject.test_sid_string_S-1-3-0.ad_dc ^samba.tests.sid_strings.+.SidStringsAsDnSearchWithDnObject.test_sid_string_S-1-5-3.2-579.ad_dc ^samba.tests.sid_strings.+.SidStringsAsDnSearchWithDnObject.test_sid_string_s-1-5-1234-5678.ad_dc