From: Jason Ish <jason.ish@oisf.net>
Date: Fri, 13 Nov 2020 19:05:48 +0000 (-0600)
Subject: dns: fix leak in dns v1 logging
X-Git-Tag: suricata-6.0.1~68
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d8242c5d07bda49eeac539c99eb3267190bb8e1e;p=thirdparty%2Fsuricata.git

dns: fix leak in dns v1 logging

Intermediate JsonBuilder object was not being freed.

Redmine issue:
https://redmine.openinfosecfoundation.org/issues/4086
---

diff --git a/src/output-json-dns.c b/src/output-json-dns.c
index f08d562ceb..1e922d9b63 100644
--- a/src/output-json-dns.c
+++ b/src/output-json-dns.c
@@ -381,6 +381,7 @@ static int JsonDnsLoggerToClient(ThreadVars *tv, void *thread_data,
                 break;
             }
             jb_set_object(jb, "dns", answer);
+            jb_free(answer);
 
             MemBufferReset(td->buffer);
             OutputJsonBuilderBuffer(jb, td->file_ctx, &td->buffer);
@@ -401,6 +402,7 @@ static int JsonDnsLoggerToClient(ThreadVars *tv, void *thread_data,
                 break;
             }
             jb_set_object(jb, "dns", answer);
+            jb_free(answer);
 
             MemBufferReset(td->buffer);
             OutputJsonBuilderBuffer(jb, td->file_ctx, &td->buffer);