From: Simon Marchi <simon.marchi@efficios.com>
Date: Fri, 27 Feb 2026 20:05:06 +0000 (-0500)
Subject: gdb: change gdbarch_return_in_first_hidden_param_p to return bool
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d87a4bcf0405091ba70c582016e459cfae4f6c71;p=thirdparty%2Fbinutils-gdb.git

gdb: change gdbarch_return_in_first_hidden_param_p to return bool

Change-Id: I49c58e5c1728bc4db735d618a1f3cf8c40dc1967
Approved-By: Tom Tromey <tom@tromey.com>
---

diff --git a/gdb/arch-utils.c b/gdb/arch-utils.c
index bb20bd3d578..2831226f44f 100644
--- a/gdb/arch-utils.c
+++ b/gdb/arch-utils.c
@@ -893,7 +893,7 @@ default_gen_return_address (struct gdbarch *gdbarch,
   error (_("This architecture has no method to collect a return address."));
 }
 
-int
+bool
 default_return_in_first_hidden_param_p (struct gdbarch *gdbarch,
 					struct type *type)
 {
diff --git a/gdb/arch-utils.h b/gdb/arch-utils.h
index 91c4c220fd1..e3bbd540f37 100644
--- a/gdb/arch-utils.h
+++ b/gdb/arch-utils.h
@@ -319,8 +319,8 @@ extern void default_gen_return_address (struct gdbarch *gdbarch,
 
 extern const char *default_auto_wide_charset (void);
 
-extern int default_return_in_first_hidden_param_p (struct gdbarch *,
-						   struct type *);
+extern bool default_return_in_first_hidden_param_p (struct gdbarch *,
+						    struct type *);
 
 extern int default_insn_is_call (struct gdbarch *, CORE_ADDR);
 extern int default_insn_is_ret (struct gdbarch *, CORE_ADDR);
diff --git a/gdb/gdbarch-gen.c b/gdb/gdbarch-gen.c
index 4d4e54783d2..26385e9a07b 100644
--- a/gdb/gdbarch-gen.c
+++ b/gdb/gdbarch-gen.c
@@ -2575,7 +2575,7 @@ set_gdbarch_update_call_site_pc (struct gdbarch *gdbarch,
   gdbarch->update_call_site_pc = update_call_site_pc;
 }
 
-int
+bool
 gdbarch_return_in_first_hidden_param_p (struct gdbarch *gdbarch, struct type *type)
 {
   gdb_assert (gdbarch != NULL);
diff --git a/gdb/gdbarch-gen.h b/gdb/gdbarch-gen.h
index 9f0c965a2f1..18ced1f0323 100644
--- a/gdb/gdbarch-gen.h
+++ b/gdb/gdbarch-gen.h
@@ -499,8 +499,8 @@ extern void set_gdbarch_update_call_site_pc (struct gdbarch *gdbarch, gdbarch_up
    implement it to a target-dependent feature.  So that we need such hook here
    to be aware of this in GDB. */
 
-typedef int (gdbarch_return_in_first_hidden_param_p_ftype) (struct gdbarch *gdbarch, struct type *type);
-extern int gdbarch_return_in_first_hidden_param_p (struct gdbarch *gdbarch, struct type *type);
+typedef bool (gdbarch_return_in_first_hidden_param_p_ftype) (struct gdbarch *gdbarch, struct type *type);
+extern bool gdbarch_return_in_first_hidden_param_p (struct gdbarch *gdbarch, struct type *type);
 extern void set_gdbarch_return_in_first_hidden_param_p (struct gdbarch *gdbarch, gdbarch_return_in_first_hidden_param_p_ftype *return_in_first_hidden_param_p);
 
 typedef CORE_ADDR (gdbarch_skip_prologue_ftype) (struct gdbarch *gdbarch, CORE_ADDR ip);
diff --git a/gdb/gdbarch_components.py b/gdb/gdbarch_components.py
index 9d84b2ca8c9..3eb2930fd5d 100644
--- a/gdb/gdbarch_components.py
+++ b/gdb/gdbarch_components.py
@@ -953,7 +953,7 @@ by language and its ABI, such as C++.  Unfortunately, compiler may
 implement it to a target-dependent feature.  So that we need such hook here
 to be aware of this in GDB.
 """,
-    type="int",
+    type="bool",
     name="return_in_first_hidden_param_p",
     params=[("struct type *", "type")],
     predefault="default_return_in_first_hidden_param_p",
diff --git a/gdb/m68k-tdep.c b/gdb/m68k-tdep.c
index cd4e56edca0..544b9cb39ed 100644
--- a/gdb/m68k-tdep.c
+++ b/gdb/m68k-tdep.c
@@ -1089,11 +1089,11 @@ m68k_get_longjmp_target (const frame_info_ptr &frame, CORE_ADDR *pc)
 /* This is the implementation of gdbarch method
    return_in_first_hidden_param_p.  */
 
-static int
+static bool
 m68k_return_in_first_hidden_param_p (struct gdbarch *gdbarch,
 				     struct type *type)
 {
-  return 0;
+  return false;
 }
 
 /* System V Release 4 (SVR4).  */
diff --git a/gdb/sh-tdep.c b/gdb/sh-tdep.c
index f67edc08982..251d58ff76e 100644
--- a/gdb/sh-tdep.c
+++ b/gdb/sh-tdep.c
@@ -2207,11 +2207,11 @@ sh_iterate_over_regset_sections (struct gdbarch *gdbarch,
 /* This is the implementation of gdbarch method
    return_in_first_hidden_param_p.  */
 
-static int
+static bool
 sh_return_in_first_hidden_param_p (struct gdbarch *gdbarch,
 				     struct type *type)
 {
-  return 0;
+  return false;
 }
 
 
diff --git a/gdb/tic6x-tdep.c b/gdb/tic6x-tdep.c
index 79ed5fa2992..0fa66f49553 100644
--- a/gdb/tic6x-tdep.c
+++ b/gdb/tic6x-tdep.c
@@ -1123,11 +1123,11 @@ tic6x_get_longjmp_target (const frame_info_ptr &frame, CORE_ADDR *pc)
 /* This is the implementation of gdbarch method
    return_in_first_hidden_param_p.  */
 
-static int
+static bool
 tic6x_return_in_first_hidden_param_p (struct gdbarch *gdbarch,
 				      struct type *type)
 {
-  return 0;
+  return false;
 }
 
 static struct gdbarch *