From: Shawn Routhier <sar@isc.org>
Date: Tue, 3 Nov 2015 00:38:50 +0000 (-0800)
Subject: [trac4090] Update per second set of review comments
X-Git-Tag: trac4116_base^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d87d517b8edf0307d0d3a70c2be2ea19b398308f;p=thirdparty%2Fkea.git

[trac4090] Update per second set of review comments

Remove change log entry as it isn't needed

Update eval log description in user guide.
---

diff --git a/ChangeLog b/ChangeLog
index 8058ef04bf..cd2ad8527b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,7 +1,3 @@
-XXXX.	[func]		sar
-	Added client classification substring token.
-	(Trac #4090, git <tbd>
-
 1041.	[func]		tomek
 	A new library, libkea-eval has been edded. It is not functional
 	yet, but its purpose is to provide a generic expression
diff --git a/doc/guide/logging.xml b/doc/guide/logging.xml
index 0924c152ac..25dd24749e 100644
--- a/doc/guide/logging.xml
+++ b/doc/guide/logging.xml
@@ -221,8 +221,8 @@
           </listitem>
           <listitem>
             <simpara><command>kea-dhcp4.eval</command> - this logger is used
-            to log messages relating to the evaluation code, primarily used
-            by the client classification routines.</simpara>
+            to log messages relating to the client classification expression
+            evaluation code.</simpara>
           </listitem>
           <listitem>
             <simpara><command>kea-dhcp4.hooks</command> - this logger is used
@@ -309,8 +309,8 @@
           </listitem>
           <listitem>
             <simpara><command>kea-dhcp6.eval</command> - this logger is used
-            to log messages relating to the evaluation code, primarily used
-            by the client classification routines.</simpara>
+            to log messages relating to the client classification expression
+            evaluation code.</simpara>
           </listitem>
           <listitem>
             <simpara><command>kea-dhcp6.hooks</command> - this logger is used
diff --git a/src/lib/eval/Makefile.am b/src/lib/eval/Makefile.am
index b8a833c9af..05c4902e08 100644
--- a/src/lib/eval/Makefile.am
+++ b/src/lib/eval/Makefile.am
@@ -22,6 +22,7 @@ libkea_eval_la_CPPFLAGS = $(AM_CPPFLAGS)
 libkea_eval_la_LIBADD   = $(top_builddir)/src/lib/exceptions/libkea-exceptions.la
 libkea_eval_la_LIBADD  += $(top_builddir)/src/lib/dhcp/libkea-dhcp++.la
 libkea_eval_la_LIBADD  += $(top_builddir)/src/lib/log/libkea-log.la
+libkea_eval_la_LIBADD  += $(top_builddir)/src/lib/util/libkea-util.la
 libkea_eval_la_LIBADD  += $(LOG4CPLUS_LIBS) $(CRYPTO_LIBS)
 
 libkea_eval_la_LDFLAGS  = -no-undefined -version-info 3:0:0