From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Wed, 4 Sep 2019 18:02:27 +0000 (+0300)
Subject: auth: Set auth_request successful before auth_request_finished event
X-Git-Tag: 2.3.9~196
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d87ee9cc73693eea8b484d9b7846f5d04e06cbdb;p=thirdparty%2Fdovecot%2Fcore.git

auth: Set auth_request successful before auth_request_finished event

Otherwise the event never has success=yes parameter.
---

diff --git a/src/auth/auth-request.c b/src/auth/auth-request.c
index 6a819438ba..212a28a504 100644
--- a/src/auth/auth-request.c
+++ b/src/auth/auth-request.c
@@ -298,6 +298,7 @@ void auth_request_success_continue(struct auth_policy_check_ctx *ctx)
 		auth_request_fail(request);
 		return;
 	}
+	request->successful = TRUE;
 
 	/* log before delay */
 	auth_request_log_finished(request);
@@ -309,7 +310,6 @@ void auth_request_success_continue(struct auth_policy_check_ctx *ctx)
 		return;
 	}
 
-	request->successful = TRUE;
 	if (ctx->success_data->used > 0 && !request->final_resp_ok) {
 		/* we'll need one more SASL round, since client doesn't support
 		   the final SASL response */