From: Nicolas Coden Date: Thu, 22 Nov 2018 20:39:55 +0000 (+0100) Subject: chore: temporary disable tree-shaking #11586 X-Git-Tag: v6.6.0~3^2~53^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d8bcc3ac0019e99fde0886434a31bc312a3f509e;p=thirdparty%2Ffoundation%2Ffoundation-sites.git chore: temporary disable tree-shaking #11586 Despite the previous attempts to make Foundation compatible with tree shaking (#11445, #11497 and #11508), Foundation is used with side-effects (on jQuery) and cannot be considered as "without side-effects" for tree-shaking purposes. This commit remove the "sideEffects: false" label and thus disable tree-shaking support, until the Foundation API and usage is changed to not implicitely rely on the global jQuery object. Closes https://github.com/zurb/foundation-sites/issues/11586 Related to: - https://github.com/zurb/foundation-sites/pull/11508 - https://github.com/zurb/foundation-sites/pull/11497 - https://github.com/zurb/foundation-sites/pull/11445 --- diff --git a/package.json b/package.json index 2e86a86fb..1ca6d4532 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,6 @@ "jsnext:main": "dist/js/foundation.esm.js", "esnext": "dist/js/foundation.es6.js", "typings": "dist/js/foundation.d.ts", - "sideEffects": false, "description": "The most advanced responsive front-end framework in the world.", "author": "ZURB (http://foundation.zurb.com)", "homepage": "http://foundation.zurb.com/sites",