From: Frédéric Buclin <LpSolit@gmail.com>
Date: Tue, 17 Apr 2012 00:15:59 +0000 (+0200)
Subject: Bug 745080: Voting extension causes database deadlocks
X-Git-Tag: bugzilla-4.2.1~7
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d8d3bd333243ebc01630b576a406c6b78725e0bf;p=thirdparty%2Fbugzilla.git

Bug 745080: Voting extension causes database deadlocks
r=glob a=LpSolit
---

diff --git a/extensions/Voting/Extension.pm b/extensions/Voting/Extension.pm
index 6a90176ecd..ead81266a6 100644
--- a/extensions/Voting/Extension.pm
+++ b/extensions/Voting/Extension.pm
@@ -486,7 +486,10 @@ sub _page_user {
         }
     }
 
-    $dbh->do('DELETE FROM votes WHERE vote_count <= 0');
+    if ($canedit && $bug) {
+        $dbh->do('DELETE FROM votes WHERE vote_count = 0 AND who = ?',
+                 undef, $who->id);
+    }
     $dbh->bz_commit_transaction();
 
     $vars->{'canedit'} = $canedit;