From: Frédéric Buclin <LpSolit@gmail.com>
Date: Thu, 22 Apr 2010 18:14:26 +0000 (+0200)
Subject: Bug 561129: Various warnings thrown by Search.pm: Perl 5.12 complains for lc(undef... 
X-Git-Tag: bugzilla-3.7.1~106
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d8e899bace75e1f4bd99443baaeaebac8b819251;p=thirdparty%2Fbugzilla.git

Bug 561129: Various warnings thrown by Search.pm: Perl 5.12 complains for lc(undef) and uc(undef)
r/a=mkanat
---

diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm
index c1e40fd4ba..91af8162d2 100644
--- a/Bugzilla/Search.pm
+++ b/Bugzilla/Search.pm
@@ -398,8 +398,8 @@ sub init {
         }
     }
 
-    my $chfieldfrom = trim(lc($params->param('chfieldfrom'))) || '';
-    my $chfieldto = trim(lc($params->param('chfieldto'))) || '';
+    my $chfieldfrom = trim(lc($params->param('chfieldfrom') || ''));
+    my $chfieldto = trim(lc($params->param('chfieldto') || ''));
     $chfieldfrom = '' if ($chfieldfrom eq 'now');
     $chfieldto = '' if ($chfieldto eq 'now');
     my @chfield = $params->param('chfield');
@@ -1190,8 +1190,7 @@ sub BuildOrderBy {
 sub split_order_term {
     my $fragment = shift;
     $fragment =~ /^(.+?)(?:\s+(ASC|DESC))?$/i;
-    my ($column_name, $direction) = (lc($1), uc($2));
-    $direction ||= "";
+    my ($column_name, $direction) = (lc($1), uc($2 || ''));
     return wantarray ? ($column_name, $direction) : $column_name;
 }