From: Martin Kletzander <mkletzan@redhat.com>
Date: Mon, 25 Mar 2013 15:50:27 +0000 (+0100)
Subject: Fix virConnectOpen.*() name requirements
X-Git-Tag: v1.0.4-rc2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d8ed386c07f24c3bcea2989aca0b86c1c10a2fb6;p=thirdparty%2Flibvirt.git

Fix virConnectOpen.*() name requirements

virConnectOpenAuth didn't require 'name' to be specified (VIR_DEBUG
used NULLSTR() for the output) and by default, if name == NULL, the
default connection uri is used.  This was not indicated in the
documentation and wasn't checked for in other API's VIR_DEBUG outputs.
---

diff --git a/src/libvirt.c b/src/libvirt.c
index 1624776be1..4b9ea75991 100644
--- a/src/libvirt.c
+++ b/src/libvirt.c
@@ -1334,7 +1334,7 @@ failed:
 
 /**
  * virConnectOpen:
- * @name: URI of the hypervisor
+ * @name: (optional) URI of the hypervisor
  *
  * This function should be called first to get a connection to the
  * Hypervisor and xen store
@@ -1362,7 +1362,7 @@ virConnectOpen(const char *name)
     if (virInitialize() < 0)
         goto error;
 
-    VIR_DEBUG("name=%s", name);
+    VIR_DEBUG("name=%s", NULLSTR(name));
     virResetLastError();
     ret = do_open(name, NULL, 0);
     if (!ret)
@@ -1376,7 +1376,7 @@ error:
 
 /**
  * virConnectOpenReadOnly:
- * @name: URI of the hypervisor
+ * @name: (optional) URI of the hypervisor
  *
  * This function should be called first to get a restricted connection to the
  * library functionalities. The set of APIs usable are then restricted
@@ -1397,7 +1397,7 @@ virConnectOpenReadOnly(const char *name)
     if (virInitialize() < 0)
         goto error;
 
-    VIR_DEBUG("name=%s", name);
+    VIR_DEBUG("name=%s", NULLSTR(name));
     virResetLastError();
     ret = do_open(name, NULL, VIR_CONNECT_RO);
     if (!ret)
@@ -1411,7 +1411,7 @@ error:
 
 /**
  * virConnectOpenAuth:
- * @name: URI of the hypervisor
+ * @name: (optional) URI of the hypervisor
  * @auth: Authenticate callback parameters
  * @flags: bitwise-OR of virConnectFlags
  *