From: Harlan Stenn <stenn@ntp.org>
Date: Wed, 12 Jul 2017 10:40:04 +0000 (-0400)
Subject: Use strlcpy() to copy strings, not memcpy()
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d90a5d3ee188a45a2cfda916c2d9eabab4bf7c00;p=thirdparty%2Fntp.git

Use strlcpy() to copy strings, not memcpy()

bk: 5965fc84KrdHrKzumgttIu9NTrzndQ
---

diff --git a/ChangeLog b/ChangeLog
index 8486ad127..278431414 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,7 @@
 ---
 
 * [Bug 3358] Spurious KoD log messages in .INIT. phase.  HStenn.
+* Use strlcpy() to copy strings, not memcpy().  HStenn.
 
 ---
 (4.2.8p10) 2017/03/21 Released by Harlan Stenn <stenn@ntp.org>
diff --git a/sntp/tests/packetProcessing.c b/sntp/tests/packetProcessing.c
index 660b5b6e2..8a8427af5 100644
--- a/sntp/tests/packetProcessing.c
+++ b/sntp/tests/packetProcessing.c
@@ -76,7 +76,7 @@ PrepareAuthenticationTest(
 	key_ptr->next = NULL;
 	key_ptr->key_id = key_id;
 	key_ptr->key_len = key_len;
-	memcpy(key_ptr->type, "MD5", 3);
+	strlcpy(key_ptr->type, "MD5", sizeof key_ptr->type);
 
 	TEST_ASSERT_TRUE(key_len < sizeof(key_ptr->key_seq));