From: James Jones Date: Fri, 21 Oct 2022 17:50:25 +0000 (-0500) Subject: Check fr_event_timer_in() return value (CID #1503926) (#4774) X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=d90f2f8426a357afa84714e8bfad4ab7b74d7b00;p=thirdparty%2Ffreeradius-server.git Check fr_event_timer_in() return value (CID #1503926) (#4774) * Check fr_event_timer_in() return value (CID #1503926) * Assert and error if we can't insert timer events Co-authored-by: Arran Cudbard-Bell --- diff --git a/src/lib/ldap/connection.c b/src/lib/ldap/connection.c index d3bc487d264..f7ed270cf68 100644 --- a/src/lib/ldap/connection.c +++ b/src/lib/ldap/connection.c @@ -967,8 +967,8 @@ fr_ldap_thread_trunk_t *fr_thread_ldap_trunk_get(fr_ldap_thread_t *thread, char /* * Insert event to close trunk if it becomes idle */ - fr_event_timer_in(found, thread->el, &found->ev, thread->config->idle_timeout, - _ldap_trunk_idle_timeout, found); + if (!fr_cond_assert_msg(fr_event_timer_in(found, thread->el, &found->ev, thread->config->idle_timeout, + _ldap_trunk_idle_timeout, found) == 0, "cannot insert trunk idle event")) goto error; /* * Attempt to discover what type directory we are talking to